Repository navigation
Do not add ':None' port when rebuilding URIs - #446
Draft
amantebriwal4321 wants to merge 1 commit into
Draft
amantebriwal4321 wants to merge 1 commit into
amantebriwal4321 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links between questions in the ZIM came out as
//:None/../../questions/.... Inrebuild_uri(),first(str(port), str(uri.port), "")turns a missing port into the string "None", so every rewritten link got:Noneadded. The fix only converts the port to a string when there is one. I added 3 tests in tests/utils/test_misc.py for no port, an explicit port and a port taken from the URI, and all three fail on main. I couldn't install libmagic locally, so I ran the suite with a stub and haven't built a real ZIM.Fixes #443