Skip to content

[fix] Close SSH channel on command timeout #1424 - #1529

Closed
sunandapandit03 wants to merge 1 commit into
openwisp:masterfrom
sunandapandit03:fix/1424-ssh-timeout-cleanup
Closed

sunandapandit03 wants to merge 1 commit into
openwisp:masterfrom
sunandapandit03:fix/1424-ssh-timeout-cleanup

Conversation

@sunandapandit03

Copy link
Copy Markdown

Close the channel when exec_command times out so the server-side session is released, and re-raise socket.timeout with a bare raise to preserve the original traceback.

Related to #1424

Checklist

Reference to Existing Issue

Closes #.

Description of Changes

Please describe these changes.

Screenshot

Please include any relevant screenshots.

Close the channel when exec_command times out so the server-side session is released, and re-raise socket.timeout with a bare raise to preserve the original traceback.

Related to openwisp#1424
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one): 1
  • ai-review
🚫 Excluded labels (none allowed): 1
  • invalid

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: e589bcbe-fbd3-40ca-ac6a-767481c2b719

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@openwisp-companion

Copy link
Copy Markdown

Hi @sunandapandit03,

Thanks for your contribution to OpenWISP.

This pull request has been flagged as invalid because it does not link to a validated issue.

Link this pull request to a validated issue by adding Fixes #ISSUE_NUMBER, Closes #ISSUE_NUMBER, or Related to #ISSUE_NUMBER to its description.

See the contributing guidelines and Anti AI Spam Policy.

This pull request will be closed 24 hours after this comment if it remains invalid.

Read how to find a validated issue.

Join the developer chat to ask questions or coordinate.

Thank you for your understanding.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 98.362% (+0.001%) from 98.361% — sunandapandit03:fix/1424-ssh-timeout-cleanup into openwisp:master

@openwisp openwisp temporarily blocked sunandapandit03 Oct 23, 2026
@openwisp-companion

Copy link
Copy Markdown

This pull request was closed because it was not linked to a validated issue within 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants