Repository navigation
arm64 signed char fix - #98
Merged
Merged
Conversation
Member
|
Output in log is looking good on ubuntu-arm64! https://github.com/ilia-nikiforov-umn/kim-api/actions/runs/22048799752/job/63702502959 I'll expand the workflow to run on some more platforms tomorrow. @ellio167 does this look good contingent on my tests? |
Member
|
Hi,
Yeah, I guess that is probably the simplest solution here. Seems OK.
Ryan
…On Sun, Feb 15, 2026 at 9:14 PM ilia Nikiforov ***@***.***> wrote:
*ilia-nikiforov-umn* left a comment (openkim/kim-api#98)
<#98 (comment)>
Output in log is looking good on ubuntu-arm64!
https://github.com/ilia-nikiforov-umn/kim-api/actions/runs/22048799752/job/63702502959
I'll expand the workflow to run on some more platforms tomorrow. @ellio167
<https://github.com/ellio167> does this look good contingent on my tests?
—
Reply to this email directly, view it on GitHub
<#98 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFXFQ7GR3NOVF5U4YVXTVL4MEYX7AVCNFSM6AAAAACVHN7XCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSMBWGIYTGOJQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
Decoded output looks good on all available runners: This is ready to merge as far as I'm concerned |
nav-mohan
approved these changes
Feb 17, 2026
nav-mohan
left a comment
nav-mohan
left a comment
Contributor
There was a problem hiding this comment.
looks good. thanks amit!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ilia-nikiforov-umn @nav-mohan
Replaced
charwithsigned charwherever possible in the base64 module. This should fix the arm64 issues. Please review and test once. I did not have exact tests.