Repository navigation
Conversation
Author
|
Could a maintainer authorize the workflows for current head The latest Pull Request run and Arborist run both still report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #4280 by emitting one aggregate warning when a public lockfile is saved with missing provenance for non-bundled registry dependencies. A real
Arborist.reify()test covers the case where an installed dependency is present but neither public nor hidden lockfile is present: the rebuilt entry retains unknownresolvedandintegrity, and the caller receives the warning.omitLockfileRegistryResolved.Validation
At exact published head
2e9c314:tap --100 --jobs=2 -R classicsuite passes 60/60 test files: 5,189 assertions passing, three platform-specific skips, zero failures, and 100% statements, branches, functions, and lines. An isolated Node 22.23.1 checkout also passes all 60 Arborist files after an offline lockfile install; coverage was disabled for that Node 22 run.latestat7b0c2e8f. In an isolated, uncommitted merge,npm ci --ignore-scripts --no-audit --no-fund --prefer-offline --registry=https://registry.npmjs.orginstalled the currentlatestlockfile dependencies. The full Arboristtap --100 --jobs=2 -R classicsuite then passes 60/60 files: 5,219 assertions passing, three platform-specific skips, zero failures, and 100% statements, branches, functions, and lines. This validates the overlappingbuild-ideal-tree.jstest file against current upstream. The PR branch was not rebased or pushed for this check.installandciCLI command suites pass. A real offlinenpm installin a seeded installed-dependency project emits the aggregate provenance warning and saves a lockfile with unknownresolvedandintegritystill absent.Arborist.reify()warning case failed on the pre-PR parent because no warning was emitted. Two existing no-old-lockfile fixtures now require the new provenance warning and still reject the old-lockfile warning.node --checkandgit diff --checkpass.These are local Linux Arborist and focused CLI checks, not a full npm monorepo run. The Arborist hosted workflow is awaiting maintainer approval and has not run jobs; maintainer review remains pending. Implementation and tests were AI-assisted and received separate AI code reviews. No human review is claimed.