Repository navigation
Backport 5926 v7.x - #6105
Closed
subhaushsingh wants to merge 2 commits into
Closed
Backport 5926 v7.x#6105subhaushsingh wants to merge 2 commits into
subhaushsingh wants to merge 2 commits into
Conversation
Fixes nodejs#5923 (cherry picked from commit e049c53)
Signed-off-by: Subh Aush Singh <subhaushsingh@gmail.com>
Member
|
rebased for 7.x |
Member
|
This duplicates the automated backport PR #6093, so I’m closing it in favor of that one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Refs #6091
Rationale
Fixes a process crash that occurs when a fetch request with a
FormDatabody is aborted, resulting inERR_INVALID_STATE: ReadableStream is already closed.Changes
Backport of #5926 to v7.x. Cherry-picked cleanly from
e049c53b, with no conflicts.Features
N/A
Bug Fixes
FormDatabody.test/issue-6091.js, which reproduces the issue and fails on v7.x before the cherry-pick but passes afterward.Breaking Changes and Deprecations
N/A
Testing
test/fetch/{client-fetch,formdata,request,response,abort,abort2}.js— 113/113 tests passed.Status