Repository navigation
Stop allowing local remote servers globally - #2891
Merged
Merged
Conversation
allow_local_remote_servers=true turns off Nextcloud's protection against
server-side requests to private and loopback addresses (SSRF), for every app
and every user-supplied URL. Collabora and OnlyOffice needed it, because they
requested https://$SUBDOMAIN through Nextcloud's HTTP client, and with split
DNS or hairpin NAT that resolves to a local address, which got blocked.
The integrated components now opt in to local addresses on their own
requests ('nextcloud' => ['allow_local_address' => true]), so they keep
working without the global setting. This was checked for AIO in
nextcloud/all-in-one#9003, covering the components the VM installs as well:
- Collabora (richdocuments: RemoteOptionsService, CachedRequestService)
- Euro-Office (DocumentService)
- Talk signaling, backend notifier and recording (spreed)
- Imaginary previews (server: lib/private/Preview/Imaginary.php)
- notify_push self-test
- Admin setup checks (CheckServerResponseTrait)
ClamAV, Full Text Search and Whiteboard don't make these requests through
Nextcloud's HTTP client, so they aren't affected.
Collabora and Euro-Office no longer set the value when installed. Their
uninstall steps still delete it, and nextcloud_update.sh deletes it on every
update, so existing VMs get the protection back.
Known breakage:
- facerecognition: its Imaginary getVersion()/getInfo() requests don't opt
in.
- Setups that target private addresses on purpose are blocked now: Talk
federation and federated sharing with servers on the local network,
WebDAV external storage on a NAS, link previews of internal URLs. Webcal
subscriptions to local calendars need the dav app's webcalAllowLocalAccess
setting. Admins who need these can set allow_local_remote_servers again.
Signed-off-by: Simon L. <szaimen@e.mail.de>
szaimen
force-pushed
the
fix/drop-allow-local-remote-servers
branch
from
November 10, 2026 15:19
22c0954 to
e373211
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow_local_remote_servers=true turns off Nextcloud's protection against server-side requests to private and loopback addresses (SSRF), for every app and every user-supplied URL. Collabora and OnlyOffice needed it, because they requested https://$SUBDOMAIN through Nextcloud's HTTP client, and with split DNS or hairpin NAT that resolves to a local address, which got blocked.
The integrated components now opt in to local addresses on their own requests ('nextcloud' => ['allow_local_address' => true]), so they keep working without the global setting. This was checked for AIO in nextcloud/all-in-one#9003, covering the components the VM installs as well:
Collabora and Euro-Office no longer set the value when installed. Their uninstall steps still delete it, and nextcloud_update.sh deletes it on every update, so existing VMs get the protection back.
Known breakage:
🤖 AI (if applicable)