Skip to content

Stop allowing local remote servers globally - #2891

Merged
enoch85 merged 1 commit into
mainfrom
fix/drop-allow-local-remote-servers
Nov 10, 2026
Merged

enoch85 merged 1 commit into
mainfrom
fix/drop-allow-local-remote-servers

Conversation

@szaimen

@szaimen szaimen commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

allow_local_remote_servers=true turns off Nextcloud's protection against server-side requests to private and loopback addresses (SSRF), for every app and every user-supplied URL. Collabora and OnlyOffice needed it, because they requested https://$SUBDOMAIN through Nextcloud's HTTP client, and with split DNS or hairpin NAT that resolves to a local address, which got blocked.

The integrated components now opt in to local addresses on their own requests ('nextcloud' => ['allow_local_address' => true]), so they keep working without the global setting. This was checked for AIO in nextcloud/all-in-one#9003, covering the components the VM installs as well:

  • Collabora (richdocuments: RemoteOptionsService, CachedRequestService)
  • Euro-Office (DocumentService)
  • Talk signaling, backend notifier and recording (spreed)
  • Imaginary previews (server: lib/private/Preview/Imaginary.php)
  • notify_push self-test
  • Admin setup checks (CheckServerResponseTrait) ClamAV, Full Text Search and Whiteboard don't make these requests through Nextcloud's HTTP client, so they aren't affected.

Collabora and Euro-Office no longer set the value when installed. Their uninstall steps still delete it, and nextcloud_update.sh deletes it on every update, so existing VMs get the protection back.

Known breakage:

  • facerecognition: its Imaginary getVersion()/getInfo() requests don't opt in. (which is not compatible with nc32 and above)
  • Setups that target private addresses on purpose are blocked now: Talk federation and federated sharing with servers on the local network, WebDAV external storage on a NAS, link previews of internal URLs. Webcal subscriptions to local calendars need the dav app's webcalAllowLocalAccess setting. Admins who need these can set allow_local_remote_servers again.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

allow_local_remote_servers=true turns off Nextcloud's protection against
server-side requests to private and loopback addresses (SSRF), for every app
and every user-supplied URL. Collabora and OnlyOffice needed it, because they
requested https://$SUBDOMAIN through Nextcloud's HTTP client, and with split
DNS or hairpin NAT that resolves to a local address, which got blocked.

The integrated components now opt in to local addresses on their own
requests ('nextcloud' => ['allow_local_address' => true]), so they keep
working without the global setting. This was checked for AIO in
nextcloud/all-in-one#9003, covering the components the VM installs as well:
- Collabora (richdocuments: RemoteOptionsService, CachedRequestService)
- Euro-Office (DocumentService)
- Talk signaling, backend notifier and recording (spreed)
- Imaginary previews (server: lib/private/Preview/Imaginary.php)
- notify_push self-test
- Admin setup checks (CheckServerResponseTrait)
ClamAV, Full Text Search and Whiteboard don't make these requests through
Nextcloud's HTTP client, so they aren't affected.

Collabora and Euro-Office no longer set the value when installed. Their
uninstall steps still delete it, and nextcloud_update.sh deletes it on every
update, so existing VMs get the protection back.

Known breakage:
- facerecognition: its Imaginary getVersion()/getInfo() requests don't opt
  in.
- Setups that target private addresses on purpose are blocked now: Talk
  federation and federated sharing with servers on the local network,
  WebDAV external storage on a NAS, link previews of internal URLs. Webcal
  subscriptions to local calendars need the dav app's webcalAllowLocalAccess
  setting. Admins who need these can set allow_local_remote_servers again.

Signed-off-by: Simon L. <szaimen@e.mail.de>
@szaimen
szaimen force-pushed the fix/drop-allow-local-remote-servers branch from 22c0954 to e373211 Compare November 10, 2026 15:19
@szaimen
szaimen requested a review from enoch85 November 10, 2026 15:20
@enoch85
enoch85 merged commit d04d76c into main Nov 10, 2026
12 checks passed
@enoch85
enoch85 deleted the fix/drop-allow-local-remote-servers branch November 10, 2026 16:36
@enoch85

enoch85 commented Nov 10, 2026

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants