Repository navigation
Imaginary: give sys_nice to Docker, so Imaginary reads its flags - #2888
Merged
Merged
Conversation
–cap-add=sys_nice, with an en dash, came after the image name, so Docker passed it to Imaginary. Imaginary stops reading flags at the first argument that isn't one, which made it ignore -concurrency, -enable-url-source and the rest. The install's test then got a 405, which curl -O doesn't fail on. Add the capability with --cap-add before the image, like AIO does, and make the test fail on HTTP errors. Signed-off-by: enoch85 <mailto@danielhansson.nu>
enoch85
marked this pull request as ready for review
November 10, 2026 06:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
–cap-add=sys_nice, with an en dash, came after the image name (since #2479), so Docker passed it to Imaginary as an argument. Imaginary stops reading flags there, so it ignored-concurrency 50 -enable-url-source -return-size -log-level debug. The install's test then got a 405, andcurl -Odoesn't fail on that.--cap-add=sys_niceis now a Docker option before the image name, as in AIO.Existing containers keep their arguments until Imaginary is reinstalled. Nextcloud sends the images itself, so the ignored flags don't change its previews.
Tested with the real
imaginary.shon a full install (Ubuntu 26.04 in a privileged container):main: the test request gets a 405, the install says it works, and Docker adds no capability.SYS_NICElike in AIO, and Nextcloud still gets previews from Imaginary. The new test line fails on the 405 that the old arguments give.