You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Attempt to build unified extension.ts for browser/node - #1231
This is an attempt to fix#1230 without duplicating the extension.ts file and fiddling with the import statement.
I'm pretty ignorant of javascript but this seemed to work for building both the desktop and web versions.
Minor thing, I'm not sure I agree with the feature-request label, it seems just a plain old bug.
Because this PR makes things work with both the Running the Sample in the Desktop and Running the Sample in the Web sections of README.md.
Testing on vscode.dev:
When testing this example on vscode.dev the lsp example needs an open workspace. The only way I know of to do that at least on my browser is to Open a remote repository. Maybe that should be added to the README.md?
Should we expand this PR to any other examples?
It's certainly possible that other examples in the repo could have a similar treatment, but it seems best to wait for a review before expanding the PR to more examples.
Thanks for rebasing this, I'm still both around and interested in seeing it fixed.
Let me know if there is anything I can do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dirk Bäumer (dbaeumer)
added
the
feature-request
This is an attempt to fix #1230 without duplicating the extension.ts file and fiddling with the import statement.
I'm pretty ignorant of javascript but this seemed to work for building both the desktop and web versions.