Repository navigation
feat(dotnet): support incremental group-chat replies - #8481
Open
Jitendra Singh (singh4jitendra) wants to merge 1 commit into
Open
Jitendra Singh (singh4jitendra) wants to merge 1 commit into
Jitendra Singh (singh4jitendra) wants to merge 1 commit into
Conversation
Author
|
Xiaoyun Zhang (@LittleLittleCloud), could you please review this opt-in .NET group-chat streaming implementation for #3076, or suggest the appropriate reviewer? Existing non-streaming APIs remain unchanged; 21 focused tests pass and both core target frameworks build successfully. The CLA and security checks have passed. I understand the maintenance status and would appreciate guidance on whether this feature can be considered. Thank you. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Group chats currently call
GenerateReplyAsynceven when a selected member supports incremental replies. Add opt-in streaming without changing existing non-streaming behavior:IStreamingGroupChat, implemented byGroupChatand inherited byRoundRobinGroupChat, without adding requirements to existingIGroupChatimplementations.CallStreamingAsyncand theSendStreamingAsyncextension.Validation:
dotnet test .\FocusedTests.csproj --configuration Release --no-restore --verbosity minimal- passed, 21 tests: 17 new streaming cases and 4 existing non-streaming group-chat cases. The external focused project links the actual repository test files and references the actualAutoGen.Coreproject.dotnet build .\prs\group-streaming\dotnet\src\AutoGen.Core\AutoGen.Core.csproj --configuration Release --no-restore --verbosity minimal- passed fornetstandard2.0andnet8.0, with no warnings or errors.dotnet format .\prs\group-streaming\dotnet\src\AutoGen.Core\AutoGen.Core.csproj --verify-no-changes --no-restore --include .\prs\group-streaming\dotnet\src\AutoGen.Core\GroupChat\GroupChat.cs .\prs\group-streaming\dotnet\src\AutoGen.Core\GroupChat\IStreamingGroupChat.cs .\prs\group-streaming\dotnet\src\AutoGen.Core\Extension\GroupChatExtension.cs --verbosity minimal- passed.dotnet format .\FocusedTests.csproj --verify-no-changes --no-restore --include ..\..\prs\group-streaming\dotnet\test\AutoGen.Tests\GroupChat\GroupChatStreamingTests.cs --verbosity minimal- passed.The core multi-target build and implementation formatting used .NET 9. Focused test execution used the installed .NET 10 SDK and .NET 8 runtime. The full legacy test suite could not be restored because NuGet.org TLS handshakes fail in this environment and the accessible Microsoft mirror lacks
Microsoft.SemanticKernel.Agents.Core. The documentation site build was not run.Related issue number
Closes #3076
Checks