Repository navigation
Fix repeater setup for discovered contacts and editable routes - #388
Closed
clausefoto wants to merge 3 commits into
Closed
clausefoto wants to merge 3 commits into
clausefoto wants to merge 3 commits into
Conversation
clausefoto
marked this pull request as draft
October 22, 2026 23:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Add Repeater dropdown includes discovered contacts, but login resolves only contacts saved on the companion. Selecting a discovered-only repeater therefore produces ‘Contact not found,’ even though it is visible in the list. Setup also offers no way to correct a missing route, and a failed login resets the selection.
This changes setup to two steps: select the repeater, then review its saved path, password and polling settings. Discovered-only contacts are saved to the companion and verified before login. The path is prefilled and editable, with validation for hex hops and hash widths, plus explicit direct and flood options. A failed attempt stays on the selected repeater’s settings form with entered values preserved.
Login makes one attempt per Confirm, using the existing traffic budget and timeout. After failure, the same form remains open for a manual retry. A new contact and its selected path are saved in one companion write. Regular repeater polling and background login behavior are unchanged. Route writes use a copy of the contact so an SDK mutation before a rejected save cannot alter the cached route. Contact-save errors explain the distinction between discovered and saved contacts and give a manual recovery step.
Contact and route changes are saved before authentication and remain on the companion if login fails; the form and documentation explain this. Documentation and regression tests are included.
Validation
tests/test_cli_command.pywere also reproduced on unchanged upstream code (EntityRegistrymissingentities).Related reports: #99, #153, #194.