Repository navigation
fix: escape only the text backslashes that border a placeholder - #151
Conversation
htmljs-parser only reads a backslash run as escapes right before `${` or
`$!{`, so doubling every backslash in text changed what rendered and grew on
each format. Text is now escaped with htmljs-parser's `escapeText`, given the
content that follows it, including the visible space printed for trailing
whitespace.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: e8364a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
==========================================
+ Coverage 97.16% 97.20% +0.03%
==========================================
Files 8 8
Lines 318 322 +4
Branches 56 57 +1
==========================================
+ Hits 309 313 +4
Misses 3 3
Partials 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (7)
💤 Files with no reviewable changes (1)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. WalkthroughText printing now uses Merge Risk: ⚪ Minimal · up to The backslash-formatting change has no identified issue that needs correction before merge; normal checks still apply. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 3 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
The
Textprinter doubled every backslash in text content, but htmljs-parser only reads a backslash run as escapes right before${or$!{, so each format changed what rendered and grew the run again (C:\Users→C:\\Users→C:\\\\Users), andprettier --checkcould never pass on such a file. Text is now escaped with htmljs-parser 5.16'sescapeText, given the content that follows it, which also covers the visible space printed for trailing whitespace. This fixes thetext-backslash-doublingagent-feedback item, whose fixture ran as an expected failure without a JS parser and now passes.🤖 Generated with Claude Code