Repository navigation
test(runtime-tags): let a stream's last calls reach the next serializer flush - #4493
Conversation
…er flush Since Node 26.12.1 a Request or Response body's final read settles after the serializer test helper flushes, so `_.a.r()` lands one flush later. A flush whose calls so far begin the expected ones now takes the next async work's calls too, as a render, which writes on the next tick, already does. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4493 +/- ##
==========================================
- Coverage 94.84% 94.84% -0.01%
==========================================
Files 419 419
Lines 20869 20868 -1
Branches 4157 4158 +1
==========================================
- Hits 19794 19793 -1
Misses 617 617
Partials 458 458 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Node 26.12.1 updated undici to 8.12, whose body streams now close a microtask after their last chunk (nodejs/undici#5926). The serializer tests for
RequestandResponsebodies flush right after the chunk arrives, so_.a.r()landed in a later flush they never checked, and CI fails on Node 26.A flush whose calls so far begin the expected ones now also takes the next async step's calls. Rendered output is unchanged: a render writes on the next tick, by which point both calls are queued on either Node version.
🤖 Generated with Claude Code