Repository navigation
fix(types): state uri starts with scheme, is an IRI in RDF - #292
Open
noelmcloughlin wants to merge 1 commit into
Open
noelmcloughlin wants to merge 1 commit into
noelmcloughlin wants to merge 1 commit into
Conversation
Signed-off-by: noelmcloughlin <noel.mcloughlin@gmail.com>
noelmcloughlin
changed the title
3 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linkml schema doc confirms a value of the
uritype is a RDF IRI and must be absolute since linkml/linkml#4156This PR changes the definition stating a URI starts with a scheme, an IRI in RDF, and the
string-derived type for text,Linkml PR: linkml/linkml#4207
Decision
conforms_toneeds decision. The fix seems to be RFC 3986 because that is whatformat: uriandURIaccept. Ifuriis meant to support any RDF IRI per RFC 3987 then the definition should remain but generator's format andURIshould widen.The disagreements are:
http://a.example/é, andrdflib_loaderthen refuses that graph with... is not a valid URIPart of linkml/linkml#2726 discussion, see also #2726