Repository navigation
Conversation
keymanapp-test-bot
Bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required |
sgschantz
marked this pull request as ready for review
October 22, 2026 18:26
keymanapp-test-bot
Bot
removed
the
user-test-missing
mcdurdin
approved these changes
Oct 23, 2026
mcdurdin
left a comment
mcdurdin
left a comment
Member
There was a problem hiding this comment.
LGTM; does this need user test too?
Contributor
Author
|
@mcdurdin I wanted to add a user test for this, but I don't know how to test it to force the timeout scenario without modifying the input method. Anything I can do to make the input method not respond causes some other error that prevents it reaching the code that would cause a timeout. I did test by modifying the input method and making it sleep for 4 seconds before responding and that looked good. |
Member
|
@sgschantz even a good-path test is probably not a bad idea though? Running on different devices can expose fun unexpected things |
1 of 8 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a timeout for the Accessibility response to be received by the config app from the Keyman input method so that the config app does not spin indefinitely. The input method generally responds within 100 milliseconds, and the timeout is set to 3 seconds.
Keyman Configuration must discover whether the Keyman input method has been granted the Accessibility permission by the user to know what installation steps are required. To do this, it either runs Keyman as a separate process with a special command line argument or it sends it a distributed notification.
To notify the config app of the Accessibility state, the input method sends a distributed notification in response. If this asynchronous response is not received within the timeout, then the timer will execute the not-granted response.
Build-bot: release:mac
Test-bot: skip
Fixes: #16579