Repository navigation
fix(layers): use selected vector channel for quantile options - #3964
Merged
Merged
Conversation
Signed-off-by: Igor Dykhta <igorDykhta@users.noreply.github.com>
lixun910
approved these changes
Nov 2, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the channel-specific Quantile change, though verification was not run during this review.
No open issues 🎉
What changed in this PR
Fixes vector-tile Quantile availability so fill and stroke use their own selected field metadata and active scale, keeping the two channels independent.
Changes:
- Resolves metadata and loading-time Quantile retention from the requested visual channel.
- Adds regression coverage for field combinations, active-scale retention, dynamic color, and the existing Jenks restriction.
Verification: NOT RUN during this review.
| File | Description |
|---|---|
test/browser/layer-tests/vector-tile-layer-specs.js |
Tests independent fill/stroke Quantile options and loading behavior. |
src/layers/src/vector-tile/vector-tile-layer.ts |
Uses the requested channel’s field and scale when filtering scale options. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fill-color Quantile availability incorrectly depended on the stroke field. Resolve metadata and the active scale from the requested visual channel, so fill/stroke choices stay independent and each active Quantile survives metadata loading.
Tests cover missing, non-quantile and quantile fields in both channels, loading-time scale retention, dynamic color and the existing Jenks restriction.
Verification: PASS targeted Tape (160 assertions), changed-file ESLint/Prettier and diff whitespace. FAILED as expected against unchanged master (regression reproduction). PASS full
yarn agent:verifyon Node 24.21.0 (initial sandbox attempt failed because MCP test listeners could not bind localhost; rerun with test permissions passed). PASS independent read-only review; no actionable findings.Review: