Repository navigation
fix(release): stage the iOS static archives at their real paths - #414
Merged
Merged
Conversation
build_ios() took the same "dir:file" destination stage() does but used it whole as the install path, so the archive landed in a file literally named `ios-arm64:libkcl.a` sitting beside the go/lib/ios-arm64/ directory. Nothing downstream reads that name: the job's own `lipo -info go/lib/ios-arm64/ libkcl.a` check failed with "No such file or directory" and aborted before the vendoring commit, which is how the first release to run this path — the v0.13.2 branch — could not be vendored at all. Splitting dest the way stage() does makes the two functions agree on what a destination is. build-libkcl-mobile.yaml stages the same two archives inline with explicit paths, so it was never affected; only the vendor-libs path goes through here. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Peefy <xpf6677@163.com>
Peefy
force-pushed
the
fix/download-libs-ios-archive-path
branch
from
October 20, 2026 06:02
e644609 to
542e3ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vendor-libs.yaml's iOS job fails before it can commit anything, which blocks every release under the new release-branch process.build_ios()inhack/download-libs.shreceives the same"dir:file"destinationstage()does —go/lib/ios-arm64:libkcl.a— but uses it whole as the install path. The archive therefore lands in a file literally namedios-arm64:libkcl.asitting beside thego/lib/ios-arm64/directory, and the job's own verification immediately fails:build_ios()has never run before this: it was added in #407, after thev0.13.1tag, so v0.13.2 is its first exercise. Therelease/v0.13.1vendor run on 2026-10-13 failed for the same reason.The fix splits
destthe same waystage()does, so both functions agree on what a destination is.What is not affected
build-libkcl-mobile.yamlstages the same two archives inline with explicit paths, so it was never affected. Only thevendor-libs.yamlpath goes throughbuild_ios().Test plan
Run locally on a macOS arm64 host, which is what the job runs on:
Before:
After:
ls go/lib/shows no strayios-arm64:libkcl.a.🤖 Generated with Claude Code