Repository navigation
Conversation
Peefy
force-pushed
the
pr/unified-consistency-ci
branch
3 times, most recently
from
October 8, 2026 03:18
68accfc to
9c1749d
Compare
Item F of docs/architecture.md: a single consistency workflow replaces the per-language silos as the gate for tests/consistency/**, spec/** and the prebuilt native libs. Each binding gets one ubuntu leg (the heavy OS matrices stay in the per-language workflows), plus the legs whose failure modes are OS-specific: go on windows (purego LoadLibrary), go in the alpine musl container, go and swift on macOS, and dart on windows for the kcl.dll path. Every runner already asserts it dispatches the whole manifest, so the matrix cannot silently drop a language. Signed-off-by: Peefy <xpf6677@163.com>
$GITHUB_ENV only applies to subsequent steps, so the dart leg loaded no native library and every test that touches the core failed. Signed-off-by: Peefy <xpf6677@163.com>
The go musl leg links the prebuilt statically and never builds from source; installing the rustup musl host toolchain there fails to run (_Unwind_* symbol errors) and kills the leg before the tests. Signed-off-by: Peefy <xpf6677@163.com>
alpine has no bash; the conditional shell keeps bash everywhere else. Signed-off-by: Peefy <xpf6677@163.com>
Peefy
force-pushed
the
pr/unified-consistency-ci
branch
from
October 8, 2026 03:27
9c1749d to
7d697ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item F of
docs/architecture.md: a singleconsistency.yamlreplaces the per-language silos as the CI gate for the shared consistency suite. It follows the patternast-diff-test.yamlalready uses — one job,matrix.includeof bindings, steps gated onmatrix.binding, checkout intolib/.Legs: one
ubuntu-latestleg per binding (15 bindings; lua gets 5.4 + luajit), plus the legs whose failure modes are OS-specific:goonwindows-latest(puregoLoadLibrarypath) andmacos-latestgoin thegolang:1.25-alpine3.21container (static musl link againstgo/lib/linux-musl-amd64/libkcl.a)dartonwindows-latest(thekcl.dll, no-lib-prefix path)swiftonmacos-latest(setup-swiftcannot provision Linux)20 legs total.
Why not more OS replication
Consistency checks that every language decodes the core's output identically — the interesting variance is language-level, and the heavy per-OS matrices stay in the per-language workflows. Every runner also self-checks full manifest coverage, so this matrix cannot silently drop a language.
Notes
tests/consistency/**,spec/**,go/lib/**(prebuilt consumers),wasm/kcl.wasm,Cargo.tomland every binding dir — the same roots the per-language workflows watch.tests/consistency/**entries from their path filters once this is required.