Skip to content

fix: use correct MIME type for .ico favicon links - #2631

Closed
mrunalC27 wants to merge 1 commit into
json-schema-org:mainfrom
mrunalC27:fix/favicon-mime-type-2615
Closed

mrunalC27 wants to merge 1 commit into
json-schema-org:mainfrom
mrunalC27:fix/favicon-mime-type-2615

Conversation

@mrunalC27

Copy link
Copy Markdown

What kind of change does this PR introduce?

Bug fix

Issue Number

Fixes #2615

Summary

The favicon tags in FaviconHead (components/Layout.tsx) declared SVG MIME types (image/svg and image/svg+xml) for .ico files. Changed both to image/x-icon, the correct type for .ico files.

Screenshots

Screenshot 2026-11-07 150956

Does this PR introduce a breaking change?

No

@mrunalC27
mrunalC27 requested a review from a team as a code owner November 7, 2026 09:43
@github-project-automation github-project-automation Bot moved this to Ready to review in PR - Triage Group Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Hi @mrunalC27! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview ff6d186

@codecov

codecov Bot commented Nov 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ff13109) to head (ff6d186).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2631   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines          737       737           
  Branches       229       229           
=========================================
  Hits           737       737           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vtushar06 vtushar06 closed this Nov 7, 2026
@github-project-automation github-project-automation Bot moved this from Ready to review to Done in PR - Triage Group Nov 7, 2026

This branch was successfully deployed

1 active deployment
Preview — ff6d1867 Deployed Nov 7, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛 Bug: Incorrect MIME types declared for .ico favicon links in Layout

2 participants