Repository navigation
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2612 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 31 31
Lines 737 737
Branches 229 229
=========================================
Hits 737 737 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hi @kunalverma2512 , I've addressed the PR validation feedback, and all checks are now passing. I'm happy to make any further changes if needed. |
|
Hi @Arya-AV, thanks for putting the PR together so quickly! The I was testing out the sorting logic and just noticed a couple of small things while checking the behavior. Once those two are in place, it should be good to go! Also, as a small friendly tip, it might be great to update your PR description with all the changes you made, including replacing the inline SVG with Lucide icons, because maintainers usually really appreciate having that clear summary during the final review. Really nice progress on this! |
|
Thanks for the feedback!!@kunalverma2512 ,I've addressed both suggestions by adding secondary alphabetical sorting within each Bowtie group and correcting the sort indicator directions. I've also replaced the existing SVG icons with Lucide icons and updated the PR description with a summary of all the changes. |
|
Hi @Arya-AV, tested the latest changes and everything looks great! The sorting behavior and the updated icons work really smoothly now. You can also share your update in the Slack channel so the maintainers can see the work. Really enjoyed collaborating with you to solve this bug! |
What kind of change does this PR introduce?
Bug fix: Corrects the Bowtie column sorting behaviour on the Tools page and improves the sorting indicators and icons.
Issue Number:
Screenshots/videos:
The updated sorting behaviour was manually tested on the local website:
If relevant, did you update the documentation?
Not applicable. No documentation changes were required.
Summary
This PR fixes the Bowtie column sorting behaviour on the Tools page.
The changes include:
getBowtieData()to group tools based on Bowtie report availability.localeCompare()so that tools within each group are also sorted according to the selected direction.TableSortableColumnHeader(ChevronUpfor ascending andChevronDownfor descending).InfoandExternalLinkicons.Does this PR introduce a breaking change?
No. These changes do not introduce any breaking changes.
Checklist
contributing guidelines(https://github.com/json-schema-org/website/blob/main/CONTRIBUTING.md).