Skip to content

Fix: Consistently show low power indicator when battery is low - #254

Open
MitchMitch42 wants to merge 3 commits into
joeycastillo:mainfrom
MitchMitch42:fix-low-power-indicator
Open

MitchMitch42 wants to merge 3 commits into
joeycastillo:mainfrom
MitchMitch42:fix-low-power-indicator

Conversation

@MitchMitch42

Copy link
Copy Markdown

The low power indicator in clock_face.c does not work as intended.
When leaving the clock face while the indicator is set, the indicator does not get set when re-entering the clock face.

The reason is that the setting of the indicator happens inside the battery check function. The indicator only gets set when a battery check if performed, which only happens every 24 hours.

Solution is to show indicator when activating clock face, independent of battery check.

@MitchMitch42 MitchMitch42 changed the title Show low power indicator independent of battery check Fix: Consistently show low power indicator when battery is low Oct 26, 2026
@voloved

voloved commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

Please add a comment below the change showing that the fallthrough is on purpose:

            break;
        case EVENT_ACTIVATE:
            clock_indicate_low_available_power(state);
+           // fall-through
        case EVENT_TICK:
            current = movement_get_local_date_time();

@MitchMitch42

Copy link
Copy Markdown
Author

Please add a comment below the change showing that the fallthrough is on purpose:

            break;
        case EVENT_ACTIVATE:
            clock_indicate_low_available_power(state);
+           // fall-through
        case EVENT_TICK:
            current = movement_get_local_date_time();

Done. Good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants