Repository navigation
Fix: Consistently show low power indicator when battery is low - #254
Open
MitchMitch42 wants to merge 3 commits into
Open
MitchMitch42 wants to merge 3 commits into
MitchMitch42 wants to merge 3 commits into
Conversation
Collaborator
|
Please add a comment below the change showing that the fallthrough is on purpose: break;
case EVENT_ACTIVATE:
clock_indicate_low_available_power(state);
+ // fall-through
case EVENT_TICK:
current = movement_get_local_date_time(); |
Author
Done. Good point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The low power indicator in clock_face.c does not work as intended.
When leaving the clock face while the indicator is set, the indicator does not get set when re-entering the clock face.
The reason is that the setting of the indicator happens inside the battery check function. The indicator only gets set when a battery check if performed, which only happens every 24 hours.
Solution is to show indicator when activating clock face, independent of battery check.