Repository navigation
Conversation
Order By clauses could only be added at the end, so changing sort priority meant deleting and re-entering fields. Each row now has Move Up and Move Down buttons (disabled at the ends of the list), in both the main query and subquery builders. The row group was also labelled "Filter row N"; it is now "Order by row N" and the E2E page model follows. Closes #1753
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Order By clauses could only be added at the end, so changing sort priority meant deleting and re-entering fields. Each Order By row now has Move Up / Move Down buttons (disabled at the ends of the list). The same container is used by the main query builder and subqueries, so both get it.
FormRowButtongains an optionaldisabledpropkeywhen moved, so each row's Order/Nulls picklist state moves with itFilter row N(copy-paste from filters); it is nowOrder by row N, and the E2E page model is updated to matchTesting
query-order-by.spec.tsx(move up, move down, disabled at ends / single row)features-querytest + typecheck greenCloses #1753