Skip to content

Update Go to 1.27, GitHub Actions and dependencies - #27

Merged
alexellis merged 3 commits into
inlets:masterfrom
welteki:update-go127-dependencies
Oct 23, 2026
Merged

alexellis merged 3 commits into
inlets:masterfrom
welteki:update-go127-dependencies

Conversation

@welteki

@welteki welteki commented Oct 22, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Use Go 1.27 for GitHub Actions and the Alpine container builder, and update checkout, setup-go and release asset upload actions.

Update golang.org/x/sync to v0.24.0 and refresh vendored dependencies. The module's minimum Go version becomes 1.26 to satisfy x/sync's requirement; mixctl's errgroup usage remains compatible.

Testing

  • With Go 1.27.3: make all, go mod verify and go vet ./... passed. make all runs go test ... -cover; this repository contains no unit test files, so this checks package compilation rather than unit-test behavior.
  • make dist built all six release targets: Linux amd64, armhf (GOARM=6), arm64; macOS amd64 and arm64; Windows amd64. Verified ELF, Mach-O and PE formats and all generated SHA-256 checksums.
  • Native Linux smoke check loaded YAML rules and round-tripped TCP data through mixctl to a local echo server.
  • docker buildx build --platform linux/amd64,linux/arm/v7,linux/arm64 --output type=oci,dest=/tmp/mixctl-validation.oci.tar . passed using a container builder. Inspected all three OCI platform configurations and the architecture of each embedded binary. Existing Dockerfile casing/redundant-platform lint warnings remain.
  • Other OS/architecture binaries were cross-compiled, not executed. Container images were built and inspected, not run. No release assets or images were published and no services were deployed.

Related issues

Includes the action/dependency updates proposed individually in #22, #23, #24, #25 and #26.

Use Go 1.27 for CI and container builds and refresh checkout, setup-go and release upload actions.

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Update golang.org/x/sync to v0.24.0 and refresh vendored sources. Raise the module Go minimum to 1.26 as required by x/sync.

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
@reviewfn

This comment has been minimized.

@welteki
welteki marked this pull request as ready for review October 22, 2026 15:36
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
@reviewfn

reviewfn Bot commented Oct 23, 2026

Copy link
Copy Markdown

AI Pull Request Overview

Disclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification.

Summary

  • Updates CI and release workflows from Go 1.26 to Go 1.27.
  • Updates checkout, setup-go, and release asset upload actions.
  • Raises the module minimum to Go 1.26 and updates golang.org/x/sync to v0.24.0.
  • Refreshes vendored dependency metadata and applies Dockerfile keyword casing fixes.
  • New commits must not contain AI authorship, co-authorship, or assistance indicators; all three scoped commits comply.
  • No actionable correctness, security, compatibility, or release-process defects were identified.

Approval rating (1-10)

10/10. The toolchain, workflow, dependency, checksum, and vendored metadata updates are internally consistent, with no concrete merge-blocking risks identified.

Summary per file

Summary per file
File path Summary
.github/workflows/build.yml Updates checkout and setup-go actions and runs CI with Go 1.27.
.github/workflows/publish.yml Updates Go, checkout, setup-go, and release asset upload versions.
Dockerfile Uses Go 1.27 for builds and normalizes multi-stage AS keyword casing.
go.mod Raises the Go minimum to 1.26 and updates x/sync to v0.24.0.
go.sum Replaces obsolete x/sync checksums with v0.24.0 checksums.

Overall Assessment

The changes are coherent across CI, release automation, container builds, module metadata, checksums, and vendored metadata. The dependency update has no functional change in the vendored errgroup code used by this project, and the final diff presents no actionable issue.

Detailed Review

Detailed Review

No findings.

AI agent details.

Agent processing time: 45.948s
Environment preparation time: 3.477s
Total time from webhook: 52.43s

@alexellis
alexellis merged commit f6458e4 into inlets:master Oct 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants