Repository navigation
Store gradient stops as textures - #3553
Open
infiniwave wants to merge 1 commit into
Open
infiniwave wants to merge 1 commit into
infiniwave wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the gradient stops stored in textures instead of passed in to every vertex. By doing this, there is no longer an arbitary limit on the amount of gradient steps. This also removes the gradient being compiled out on wasm (there should be few enough attributes).
Each gradient here is stored as a Rgba32Float texture 256 texels wide, and the height of the texture grows like a Vec (doubles) as there are more stops. In the shader, I also deduplicated the gradient function as it is declared twice.
As a side note, I think this also unblocks radial gradients.