Repository navigation
Conversation
Marin2409
marked this pull request as ready for review
October 7, 2026 20:14
Marin2409
force-pushed
the
tool-workspace-crud-sdk-migration
branch
2 times, most recently
from
October 8, 2026 16:34
5ae3c5e to
5dcf678
Compare
Marin2409
marked this pull request as draft
October 8, 2026 17:28
Marin2409
marked this pull request as ready for review
October 8, 2026 20:49
Marin2409
force-pushed
the
tool-workspace-crud-sdk-migration
branch
from
October 8, 2026 21:17
53c608a to
2c1a0b8
Compare
Marin2409
marked this pull request as draft
October 9, 2026 15:20
…tamps to workspace details
…xplicit input schemas
Marin2409
force-pushed
the
tool-workspace-crud-sdk-migration
branch
from
October 12, 2026 17:41
693ed37 to
9f4fd22
Compare
Marin2409
marked this pull request as ready for review
October 12, 2026 19:39
Shweta-Deshpande
requested changes
Oct 13, 2026
| options := tfe.WorkspaceUpdateOptions{} | ||
| changed := false | ||
|
|
||
| if input.NewName != "" { |
Collaborator
There was a problem hiding this comment.
new_name is sent to the API as is, while terraform_org_name and workspace_name are trimmed and blank-checked. Please trim it and return new_name must not be blank if it is provided but empty, so it matches the other fields and gives a clearer error than the API's rejection.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues the work from #506 and takes over the Workspace crud tools migration.
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.