You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 31, 2025. It is now read-only.
Repository navigation
This repository was archived by the owner on Jan 31, 2025. It is now read-only.
Also, it's weird to me that we have consecutive commits of IWYU, sometimes a commit undoes what the previous commit.
That's clearly a bug. Probably we need to adjust the mappings a bit. I'll try to fix it.
Could we reduce the frequency of IWYU?
Well, currently, we perform the action after each commit to main, unless there is an open IWYU PR.
We could change the trigger, to a schedule, and e.g. run it once a week. This would be a bit of a resource waste if development here on the repo slows down. But, I don't have a strong opinion on this.
Ideally, the check would run on each PR, but it is simply to slow for that.
Activity
florian-kuebler commentedon Feb 8, 2023
That's clearly a bug. Probably we need to adjust the mappings a bit. I'll try to fix it.
Well, currently, we perform the action after each commit to
main, unless there is an open IWYU PR.We could change the trigger, to a schedule, and e.g. run it once a week. This would be a bit of a resource waste if development here on the repo slows down. But, I don't have a strong opinion on this.
Ideally, the check would run on each PR, but it is simply to slow for that.
florian-kuebler commentedon Feb 9, 2023
in your given examples, i can't see IWYU undo previous changes. What am I missing?