Repository navigation
fix: omit source check constraints from many-to-many join tables - #7880
Open
binaryyang wants to merge 1 commit into
Open
binaryyang wants to merge 1 commit into
binaryyang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Exclude
checktags from both source fields when constructing an automatic many-to-many join table. These constraints refer to columns on the original tables; copying them to renamed join columns causesAutoMigrateto fail (for example,email <> ''is copied onto a table containingchecked_user_email, producingno such column: email). The original tables retain their CHECK constraints.Fixes #7006.
Validation
The regression test fails on unmodified master with inherited constraints and a SQLite migration error. With the fix, it verifies successful migration and association insertion, absence of inherited join-table checks, and enforcement of checks on both original tables.
go test ./... -count=1in the root module: passed.tests/, using a temporary modfile to resolve the existing missing dependency checksums: passed.Other database dialects were not run locally.