Repository navigation
fix(schema): handle driver convertible slices - #7848
Open
zacharyarnaise wants to merge 1 commit into
Open
zacharyarnaise wants to merge 1 commit into
zacharyarnaise wants to merge 1 commit into
Conversation
zacharyarnaise
force-pushed
the
buildcond_values
branch
from
September 21, 2026 08:11
92b1e02 to
b3dd10f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-gorm/playground#859
Closes #7842
What did this pull request do?
This PR fixes
Statement.BuildConditionto treat a slice thatdatabase/sqlconverts to a single driver value as one primary key instead of expanding it into anINlist.Types that are genuinely a list (e.g.
[]string) keeps theIN (...)semantic.Go 1.27 stdlib introduced
uuid.UUID. Using it as an inline PK condition currently expands it and gives this:With this PR, it gives:
User Case Description
Being able to use Go 1.27
uuid.UUIDwithout having to wrap it in a type that implementsdriver.Valuerandsql.Scanner.uuid.UUIDimplements neither butdatabase/sqltreats it as a special case, so values convert and scan on their own.See: