Repository navigation
feat: establish viewer-scoped SQLite and secrecy foundation - #1
Conversation
453676b to
efc2584
Compare
nicolerenee
left a comment
There was a problem hiding this comment.
Reviewed at exact head efc2584 (via Claude Code, on Nicole's instruction "yes, fix it first" and her standing review delegation). One-line delta from the previously reviewed 453676b: the build-stage FROM now pulls through mirror.gcr.io and is digest-pinned (golang:1.27.3@sha256:e519d3b0..., same tag as go.mod); runtime stage and every other byte unchanged, same parent. Independent prepared-publication approval on this exact object (private anchor 08c0f12, authorization read via review_evidence); CI test and image green; merge state clean. My earlier full read of the tree still stands: no private identifiers, SHA-pinned actions, read-only top-level permissions, release credential only on pushes to main. Not covered / still pending on Nicole: provisioning the release GitHub App credentials (RELEASE_APP_CLIENT_ID variable, RELEASE_APP_PRIVATE_KEY secret); until then the release job fails on pushes to main.
Cockpit: C-1813
Implements M1 of C-1810 with a single internal SQLite boundary, viewer-scoped typed reads and writes, owner DTOs without coordination fields, query-level surprise exclusion, soft deletion/restore, configured calendar archives, and admin group management without content bypass.
Adds real on-disk database read/permission matrices, complete owner-response differential tests, cross-store claim races, persistence/migration checks, and a full-source structural guard with negative fixtures, transitive API type resolution, approved operation signatures, input-only contexts and checker-only parser tooling. Documents schema, API, migration/rollback and release prerequisites. Adds Conventional Commits/release-please, immutable main images, release images, and PR/merge-queue container build paths.
Local validation: source guard, formatting, vet, real SQLite tests with race detector, repeated claim/differential tests and CGO-disabled binary smoke initialization. Container build and GitHub publishing require CI; no Docker runtime is available locally. Release automation additionally requires owner-provisioned scoped App credentials. No UI, OIDC/MCP runtime or deployment is claimed.
Workflow changes require owner review. Merge only after every check, independent exact-head review and applicable publication/owner approval gates pass.