Skip to content

Lexer and parser bug fixes - #180

Merged
yunzheng merged 1 commit into
mainfrom
lexer-parser-fixes
Nov 4, 2026
Merged

yunzheng merged 1 commit into
mainfrom
lexer-parser-fixes

Conversation

@Schamper

@Schamper Schamper commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Alternative fix for #169, would make #170 redundant.

@Schamper
Schamper requested a review from yunzheng November 3, 2026 16:04
@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (2688580) to head (b878600).

Files with missing lines Patch % Lines
dissect/cstruct/parser.py 0.00% 26 Missing ⚠️
dissect/cstruct/lexer.py 0.00% 17 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #180   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         22      22           
  Lines       3533    3554   +21     
=====================================
- Misses      3533    3554   +21     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed

codspeed Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 45 untouched benchmarks
⏩ 47 skipped benchmarks1


Comparing lexer-parser-fixes (b878600) with main (2688580)

Open in CodSpeed

Footnotes

  1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@yunzheng

yunzheng commented Nov 4, 2026

Copy link
Copy Markdown
Member

Either something went wrong with the benchmarks or everything got much slower.

@Schamper

Schamper commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

Either something went wrong with the benchmarks or everything got much slower.

I'm pinning it as a CodSpeed fluke with different runners. Merging #178 first should hopefully get us back into a correct state.

@yunzheng
yunzheng merged commit e066596 into main Nov 4, 2026
24 checks passed
@yunzheng
yunzheng deleted the lexer-parser-fixes branch November 4, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants