Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 22 22
Lines 2854 2855 +1
=====================================
- Misses 2854 2855 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
I'll take a look once the CLA on fox-it/dissect.util#142 is accepted |
Contributor
|
Surpassed by #184. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #163.
array dimensions currently suppress expression evaluation errors, so a constant containing text becomes a dynamic array size and fails only when reading data. propagate integer conversion failures as parser errors while preserving unresolved field expressions.
adds 12 regression cases covering invalid string/bytes constants, integer constants (including zero), and field-dependent lengths in compiled and interpreted mode. the six invalid-constant cases fail before the change.
validation: 121 parser/expression tests pass; ruff 0.13.1 lint and formatting, python 3.10 compatibility check, and git diff --check pass.