Repository navigation
test(cast): use vitalik.eth in live ENS tests - #18049
Merged
Merged
Conversation
emo.eth expired on 2026-09-01 and its ENSv2 reservation lapsed on 2026-11-02 at 15:10 UTC, so the Universal Resolver no longer returns a resolver for it and ens_lookup and ens_resolve fail. Cast is correct to reject an expired name; the fixture is stale. vitalik.eth resolves through the same v1 fallback path and is registered until 2048. Amp-Thread-ID: https://ampcode.com/threads/T-01a19cb3-d43e-7311-a7f3-314f527b0fca
stevencartavia
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr and
mattsse
as code owners
November 2, 2026 16:01
mablr
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ens_lookupandens_resolvestarted failing on master because emo.eth expired and its ENSv2 grace reservation lapsed today, so the Universal Resolver no longer returns a resolver for it. Cast is behaving correctly; the fixture is stale. This switches both tests to vitalik.eth, which resolves through the same path and is registered until 2048.