Repository navigation
feat(evm): warn when an explicit --network does not match a fork - #18036
Closed
SibghatUllah1997 wants to merge 1 commit into
Closed
SibghatUllah1997 wants to merge 1 commit into
SibghatUllah1997 wants to merge 1 commit into
Conversation
SibghatUllah1997
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse and
stevencartavia
as code owners
November 2, 2026 12:02
Author
|
Closing in favour of #18037, which also dedups the warning and adds CLI coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17994
Motivation
When
--networkis passed explicitly, a fork of a chain from a different network family is accepted silently and then executed with the selected network's rules. That's easy to miss and can lead to confusing results, as described in #17994.Solution
When the network was selected explicitly (so the endpoint family check is not enforced),
create_forknow emits a warning if the selected network doesn't support the fork's source network. The warning names the fork's chain ID, the fork's network and the selected network, for example:It deliberately uses the chain ID rather than the RPC URL so that API keys embedded in URLs are never printed. Behavior is otherwise unchanged; this is a warning only.
PR Checklist