Repository navigation
Conversation
desync.Log is now a *slog.Logger that discards output by default. --verbose installs a text handler on stderr at debug level. Call sites pass fields as slog attributes, with errors under the "error" key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
github.com/sirupsen/logruswith the standard library'slog/slogand drop logrus from the module dependencies.desync.Logis a*slog.Loggerbacked byslog.DiscardHandler, so the library stays silent unless a caller installs a handler.--verbosesetsdesync.Logto aslog.TextHandleron stderr at debug level.WithError(err)becomes an"error"attribute, and the per-request loggers in the GCS and HTTP stores useLog.With(...).This changes the exported API:
desync.Logwas a*logrus.Logger, so library users that configure or call it need to switch to*slog.Logger. The--verboseoutput format also changes to slog'stime=… level=DEBUG msg=… key=value.