Repository navigation
Remove dead code and unused dependencies - #211
Merged
Merged
Conversation
- tizen_renderer_egl.cc: drop the tbm_dummy_display fallback. Its only consumer was the NUI_SUPPORT branch removed in flutter-tizen#184. Since then a null display skips eglCreateWindowSurface and fails on EGL_NO_SURFACE anyway, after initializing EGL on a dummy display that was never destroyed. A null display now fails fast with an error log. - tizen_window_tcore_wl.cc: stop fetching and freeing `keyname` in the key-down/key-up handlers; the value was never used. - BUILD.gn: drop the common_cpp_isolate_scope dependency; nothing in the Tizen embedder references IsolateScope. No change to the shared libraries' DT_NEEDED set. Verified with arm64 ecore (all profiles + flutter_tizen_unittests) and arm64 tcore (common, tv) builds.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
xiaowei-guan
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keynamein the key-down/key-up handlers; the value was never used.No change to the shared libraries' DT_NEEDED set. Verified with arm64 ecore (all profiles + flutter_tizen_unittests) and arm64 tcore (common, tv) builds.