Skip to content

chore(c): force native symbols and remove string .Call()s - #101

Merged
davidbudzynski merged 1 commit into
fastverse:masterfrom
davidbudzynski:chore/93-force-symbols
Oct 30, 2026
Merged

davidbudzynski merged 1 commit into
fastverse:masterfrom
davidbudzynski:chore/93-force-symbols

Conversation

@davidbudzynski

Copy link
Copy Markdown
Collaborator

Closes #93.

Change

  • Add R_forceSymbols(dll, TRUE) in src/init.c.
  • Use the registered symbols for clearData(), shareData() and getData() in R/call.R.
  • No string .Call() lookups remain.

Test

  • R CMD INSTALL passes.
  • shareData() / getData() / clearData() round-trip passes.
  • All tinytest expectations pass: 1599 results, all ok.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.76%. Comparing base (99413b6) to head (d2450b6).
⚠️ Report is 122 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   98.01%   96.76%   -1.25%     
==========================================
  Files          13       14       +1     
  Lines        5083     5137      +54     
==========================================
- Hits         4982     4971      -11     
- Misses        101      166      +65     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@davidbudzynski
davidbudzynski merged commit c31c31b into fastverse:master Oct 30, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(c): force native symbols and remove the last three string .Call()s

2 participants