Repository navigation
Add Qt Quick double-click gestures to the C++ API - #153
Open
mertalp-ulus wants to merge 5 commits into
Open
mertalp-ulus wants to merge 5 commits into
mertalp-ulus wants to merge 5 commits into
Conversation
Map the target into screen coordinates instead of inheriting the desktop cursor position. Cover moved windows, transformed items, and fractional positions.
mertalp-ulus
marked this pull request as ready for review
October 19, 2026 09:27
Author
|
Hi @faaxm , This PR is ready for review and adds four C++ double-click overloads for Qt Quick. Local Windows tests passed on Qt 6.11.0 and 6.11.1; Qt 6.11.0 also passed 100 gesture-suite repetitions and shared-build, installation, and consumer checks. RPC and Widgets support remain follow-up work. Could you please approve the pending workflows so the broader Qt/platform matrix can run? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #116.
Adds four C++
TestServer::mouseDoubleClickoverloads matching the existing click API: item center, relative position, relative position plus pixel offset, and button/modifiers.Qt Quick receives a complete press → release → press → double-click → release gesture. The first release can update selection before confirmation. Events use the target's window and global coordinates, correct released-button masks, and increasing timestamps that separate explicit gestures without sleeps or event-loop pumping in the backend.
Missing targets, invalid button/modifier masks, an already-held button, and unsupported backends report executor errors without starting a partial double-click. Calls enqueue work; callers must wait for an observable application result.
Scope and compatibility
Events::mouseDoubleClickimplementation.Validation
Tested source:
173dc4c38873fbc9f952e1ab697ba1927b05cc15.Upstream Qt 5.15.2, Qt 6.9.2/6.10.3, Linux/macOS, and their shared/install configurations remain unverified pending upstream CI.