Repository navigation
iocStats: load iocAdminScanMon.db with iocAdminSoft only on RTEMS - #258
Merged
Merged
Conversation
iocStats 4.0.1's iocAdminSoft.substitutions already expands iocAdminScanMon.db into iocAdminSoft.db, so loading both defines the 15 ScanMon records (<IOC>:*HZ_MODE, *HZ_UPD_TIME, SCANMON_SEVR) twice in every Linux IOC. RTEMS builds iocStats at 4226b12, where iocAdminSoft.db has no ScanMon records, so iocAdminScanMon.db is still loaded there, chosen by the image's EPICS_TARGET_ARCH. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uybqz56DqeZEh7StNv1sdT
|
Warning Review limit reachedThis review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Next included review available in 48 minutes. View limit details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
iocStats 4.0.1, the version Linux generic IOCs build, already expands
iocAdminScanMon.dbintoiocAdminSoft.dbthroughiocAdminSoft.substitutions. ThedevIocStats.iocAdminSoftmodel also loadsiocAdminScanMon.dbon its own, so every Linux IOC defines the 15 ScanMon records (<IOC>:*HZ_MODE,*HZ_UPD_TIME,SCANMON_SEVR) twice.RTEMS builds iocStats at 4226b12, where
iocAdminSoft.dbhas no ScanMon records. This PR keeps the separateiocAdminScanMon.dbload only whenEPICS_TARGET_ARCHcontainsRTEMS, usingdatabases[].enabled.Impact
ioc.substloses oneiocAdminScanMon.dbblock. The duplicate records go. Otherwise the IOC has the same records, and each ScanMon record is now defined once.iocAdminScanMon.db.How it was verified
EPICS_TARGET_ARCH,_global.get_envreturns""when the variable is unset, and withEPICS_TARGET_ARCH=RTEMS-beatnikgenerate2 loadsiocAdminScanMon.db.ibek ioc generate-schema */*.ibek.support.yaml --no-ibek-defspasses, which is the CI schema check.Do not merge until the owner says so.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Uybqz56DqeZEh7StNv1sdT