Repository navigation
fix: DragRect middle control no longer depends on mouse deltas - #730
Open
PysKa-Ratzinger wants to merge 1 commit into
Open
PysKa-Ratzinger wants to merge 1 commit into
PysKa-Ratzinger wants to merge 1 commit into
Conversation
If the user is doing any kind of coordinate manipulation on their side, like rounding the positions to the nearest integer coordinates, then the drag operation using mouse deltas will only work if their mouse moves at least that distance in a single frame. By setting the rectangle at the cursor's center while held, then this problem disappears.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user is doing any kind of coordinate manipulation on their side, like rounding the positions to the nearest integer coordinates, then the drag operation using mouse deltas will only work if their mouse moves at least that distance in a single frame, which results in the mouse cursor position diverging from the drag point.
By setting the rectangle's center at the cursor's center while held, then this problem disappears.