Repository navigation
NXT-21176: Migrate MediaControlsDecorator to a function component. - #466
Open
dan-ichim-lgp wants to merge 4 commits into
Open
dan-ichim-lgp wants to merge 4 commits into
dan-ichim-lgp wants to merge 4 commits into
Conversation
dan-ichim-lgp
changed the base branch from
develop
to
feature/functionalComponents
October 29, 2026 13:00
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/functionalComponents #466 +/- ##
================================================================
+ Coverage 81.29% 84.30% +3.00%
================================================================
Files 153 158 +5
Lines 7139 7919 +780
Branches 2167 2447 +280
================================================================
+ Hits 5804 6676 +872
+ Misses 1026 967 -59
+ Partials 309 276 -33 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alexandrumorariu
left a comment
Contributor
There was a problem hiding this comment.
Please bring back the tests removed by the second to last commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Migrated
MediaControlsDecoratorfrom a class component to a function component.Resolution
MediaControlsDecoratornow uses hooks instead of a class HOC. Playback key handling, jump pulses, the more-components panel, and the play/pause button keep the previous behavior. The public props are unchanged, so this is not an API change. The migration removes the class lifecycle so the decorator can follow the same functional pattern as the other MediaPlayer pieces.Additional Considerations
Links
NXT-21176
Comments
Enact-DCO-1.0-Signed-off-by: Dan Ichim dan.ichim@lgepartner.com