Skip to content

NXT-21176: Migrate MediaControlsDecorator to a function component. - #466

Open
dan-ichim-lgp wants to merge 4 commits into
feature/functionalComponentsfrom
feature/NXT-21176
Open

dan-ichim-lgp wants to merge 4 commits into
feature/functionalComponentsfrom
feature/NXT-21176

Conversation

@dan-ichim-lgp

@dan-ichim-lgp dan-ichim-lgp commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • I have run automated testing and it is passed
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Migrated MediaControlsDecorator from a class component to a function component.

Resolution

MediaControlsDecorator now uses hooks instead of a class HOC. Playback key handling, jump pulses, the more-components panel, and the play/pause button keep the previous behavior. The public props are unchanged, so this is not an API change. The migration removes the class lifecycle so the decorator can follow the same functional pattern as the other MediaPlayer pieces.

Additional Considerations

Links

NXT-21176

Comments

Enact-DCO-1.0-Signed-off-by: Dan Ichim dan.ichim@lgepartner.com

@dan-ichim-lgp
dan-ichim-lgp changed the base branch from develop to feature/functionalComponents October 29, 2026 13:00
@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.17341% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.30%. Comparing base (2728750) to head (cab589d).
⚠️ Report is 233 commits behind head on feature/functionalComponents.

Files with missing lines Patch % Lines
MediaPlayer/MediaControls.js 90.17% 14 Missing and 3 partials ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##           feature/functionalComponents     #466      +/-   ##
================================================================
+ Coverage                         81.29%   84.30%   +3.00%     
================================================================
  Files                               153      158       +5     
  Lines                              7139     7919     +780     
  Branches                           2167     2447     +280     
================================================================
+ Hits                               5804     6676     +872     
+ Misses                             1026      967      -59     
+ Partials                            309      276      -33     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexandrumorariu alexandrumorariu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bring back the tests removed by the second to last commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants