Skip to content

NXT-20357: Added ui test for continue5WayHold of VirtualList - #465

Open
vJIYEv wants to merge 1 commit into
release/1.11.x.developfrom
feature/NXT-20357-1.11.x
Open

vJIYEv wants to merge 1 commit into
release/1.11.x.developfrom
feature/NXT-20357-1.11.x

Conversation

@vJIYEv

@vJIYEv vJIYEv commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • I have run automated testing and it is passed
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

We don't have any test to verify the continue5WayHold prop in VirtualList.

Resolution

Added UI tests for continue5WayHold with three horizontal VirtualLists stacked vertically.

  • continue5WayHold={true}: holding the down key moves focus through all lists to the last one.
  • continue5WayHold={false}: holding the down key stops focus at the second list. The first keydown is not a repeat, so focus moves once, and the following repeats are blocked.

Additional Considerations

Links

NXT-20357

Comments

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
@codecov

codecov Bot commented Oct 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/1.11.x.develop@eb3070b). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             release/1.11.x.develop     #465   +/-   ##
=========================================================
  Coverage                          ?   82.73%           
=========================================================
  Files                             ?      153           
  Lines                             ?     7627           
  Branches                          ?     2320           
=========================================================
  Hits                              ?     6310           
  Misses                            ?     1023           
  Partials                          ?      294           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexandrumorariu alexandrumorariu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants