Repository navigation
Conversation
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/1.11.x.develop #465 +/- ##
=========================================================
Coverage ? 82.73%
=========================================================
Files ? 153
Lines ? 7627
Branches ? 2320
=========================================================
Hits ? 6310
Misses ? 1023
Partials ? 294 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
We don't have any test to verify the
continue5WayHoldprop in VirtualList.Resolution
Added UI tests for
continue5WayHoldwith three horizontal VirtualLists stacked vertically.continue5WayHold={true}: holding the down key moves focus through all lists to the last one.continue5WayHold={false}: holding the down key stops focus at the second list. The first keydown is not a repeat, so focus moves once, and the following repeats are blocked.Additional Considerations
Links
NXT-20357
Comments
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)