Skip to content

NXT-20999: Added applyMotions mixin - #461

Open
ion-andrusciac-lgp wants to merge 6 commits into
developfrom
feature/NXT-20999
Open

ion-andrusciac-lgp wants to merge 6 commits into
developfrom
feature/NXT-20999

Conversation

@ion-andrusciac-lgp

@ion-andrusciac-lgp ion-andrusciac-lgp commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • I have run automated testing and it is passed
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Added applyMotions mixin

Resolution

Added applyMotions mixin:

  • .applyMotions(@componentMotion, @tier, @selector: where): Useful for applying motion mixins to a specific tier, or targeting specific nested classes within those tiers
  • .applyMotions(@highTierMotion, @lowTierMotion, @selector: where): Mostly used when you need to apply motion mixins directly without nested classes

Additional Considerations

.applyMotions mixin uses where as a default selector. In Popup, we should keep :is(). :where() would lose to ui/Transition's slide rules.

Links

NXT-20999

Comments

Enact-DCO-1.0-Signed-off-by: Ion Andrusciac ion.andrusciac@lgepartner.com

@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.54%. Comparing base (ccf5ec6) to head (9e762bb).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #461   +/-   ##
========================================
  Coverage    83.54%   83.54%           
========================================
  Files          158      158           
  Lines         7908     7908           
  Branches      2446     2446           
========================================
  Hits          6607     6607           
  Misses        1011     1011           
  Partials       290      290           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread styles/motion-mixins.less Outdated
Comment thread Button/Button.module.less Outdated
Comment thread styles/motion-mixins.less Outdated
Comment thread Button/Button.module.less Outdated
Comment thread Popup/Popup.module.less Outdated
.inner {
.lime-enter-small-high-motion();
}
}, high, is);

@daniel-stoian-lgp daniel-stoian-lgp Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Popup.module.less passes is at every call but has no comment saying why.
Earlier we wanted a note that Popup needs :is() to override ui/Transition’s slide rules.
Please specify this in the PR description or in a comment is the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants