Repository navigation
NXT-20999: Added applyMotions mixin - #461
Open
ion-andrusciac-lgp wants to merge 6 commits into
Open
ion-andrusciac-lgp wants to merge 6 commits into
ion-andrusciac-lgp wants to merge 6 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #461 +/- ##
========================================
Coverage 83.54% 83.54%
========================================
Files 158 158
Lines 7908 7908
Branches 2446 2446
========================================
Hits 6607 6607
Misses 1011 1011
Partials 290 290 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| .inner { | ||
| .lime-enter-small-high-motion(); | ||
| } | ||
| }, high, is); |
Contributor
There was a problem hiding this comment.
Popup.module.less passes is at every call but has no comment saying why.
Earlier we wanted a note that Popup needs :is() to override ui/Transition’s slide rules.
Please specify this in the PR description or in a comment is the code
daniel-stoian-lgp
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Added
applyMotionsmixinResolution
Added
applyMotionsmixin:.applyMotions(@componentMotion, @tier, @selector: where): Useful for applying motion mixins to a specific tier, or targeting specific nested classes within those tiers.applyMotions(@highTierMotion, @lowTierMotion, @selector: where): Mostly used when you need to apply motion mixins directly without nested classesAdditional Considerations
.applyMotionsmixin useswhereas a default selector. InPopup, we should keep:is().:where()would lose to ui/Transition's slide rules.Links
NXT-20999
Comments
Enact-DCO-1.0-Signed-off-by: Ion Andrusciac ion.andrusciac@lgepartner.com