Skip to content

Integrate recommended upstream PR repairs (AI) - #1

Merged
emmett08 merged 1 commit into
masterfrom
codex/upstream-pr-integration-20260824
Aug 24, 2026
Merged

emmett08 merged 1 commit into
masterfrom
codex/upstream-pr-integration-20260824

Conversation

@emmett08

Copy link
Copy Markdown
Owner

Scope

This reviews every open pull request in the parent repository, cuthbertLab/music21, against refreshed base commit 93b49debc1b3b6c6548b4d3aedb588a0b216be9f on 24 August 2026. Five recommendations are incorporated as repaired successors; stale or unsafe heads were not merged mechanically.

Disposition

Parent PR Decision Result
#1044 Accept with repairs Preserves the harmonic/melodic abstractions and existing key modes; adds relative-scale metadata and bidirectional JazzMinorScale.
#1169 Accept with repairs Adds immutable, line-aware staff tunings and robust MusicXML import/export, including exact arbitrary decimal alterations.
#1240 Hold A 2,848-rational sweep found exact-duration corruption and unbounded note expansion; the current split/export model also loses shared tuplet semantics.
#1418 Accept with repairs Explicitly serialises slow/fast grouping for supported simple meters while retaining additive spelling and rejecting unrepresentable grouping.
#1766 Hold Draft, API-breaking, dependent on cuthbertLab#1768, and symbolic pedal bounces do not survive semantic round trips.
#1768 Accept with repairs Resolves direction-spanner endpoints by exact time, staff and optional voice; supports reversed XML ordering and cross-measure spans.
#1972 Hold Draft with broad compatibility breaks and correctness failures in equality, empty meters, invalid denominators, mutation and cache behaviour.
#2007 Accept with small repairs Adds public Stream.isAtEnd(), uses it safely in quantisation, and preserves legacy string-form end offsets.

Integration hardening

  • Bumps the parser/cache version to 11.0.0b10 so both independent MusicXML changes invalidate stale converter pickles.
  • Preserves tiny tuning decimals without rounding or schema-invalid exponent notation.
  • Adds staff-aware, ambiguous-voice, stop-before-start, cross-measure and part-cleanup direction-spanner regressions.
  • Makes LocalCorpus examples portable instead of assuming ~/Desktop exists.
  • Adds public-interface change markers, AI declarations and contributor trailers.

The published Git tree is b99c66118c6f40ab8033c74f0d13308063cfb52e, exactly matching the locally reviewed and tested tree.

Verification

  • Project multiprocess harness: 5,314 tests passed.
  • Affected integration suite: 858 tests + 89 subtests passed; later audit gate: 521 tests + 93 subtests passed.
  • ruff check music21: passed.
  • ruff check documentation: passed.
  • mypy music21: passed across 269 source files.
  • Source distribution and wheel build: passed.
  • LilyPond integration tests: passed with GNU LilyPond 2.24.3.
  • Branch is 0 commits behind refreshed master.

AI/LLM disclosure

This integration and all repair work are entirely AI written by Codex. I reviewed the complete final tree, the analyses and the test results before publication. The upstream contributor work incorporated here is credited by Co-authored-by trailers; AI output was not pasted unreviewed.

Integrate repaired successors for cuthbertLab/music21 PRs cuthbertLab#1044, cuthbertLab#1169,
cuthbertLab#1418, cuthbertLab#1768, and cuthbertLab#2007, together with integration hardening and
portable LocalCorpus examples.

This integration and repair work is entirely AI written. It incorporates
and preserves contributor work credited below, and was reviewed against
the complete final tree.

Co-authored-by: Alex <ProfessorARD@gmail.com>
Co-authored-by: Louis Bigo <louis.bigo@univ-lille.fr>
Co-authored-by: Malcolm Sailor <malcolm.sailor@gmail.com>
Co-authored-by: Greg Chapman <75333244+gregchapman-dev@users.noreply.github.com>
Co-authored-by: Sankalp Thakur <sankalphimself@gmail.com>
@emmett08
emmett08 marked this pull request as ready for review August 24, 2026 18:08
@emmett08
emmett08 merged commit d34a3bb into master Aug 24, 2026
@mscuthbert

Copy link
Copy Markdown

this is very cool -- looking forward to seeing these broken down and contributed if you feel like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants