Repository navigation
Revert: HOTFIX: ci: exclude Irt collections from EICrecon output - #1196 - #1206
Merged
Merged
Conversation
This reverts #1196 as the mitigation is now in EICrecon itself since eic/EICrecon#3067.
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
2 open issues
What changed in this PR
Reverts the CI workaround that excluded Irt collections from EICrecon output, based on the claim that the underlying issue is now fixed upstream in EICrecon.
Changes:
- Removes the
podio:output_exclude_collectionsoption from EICrecon invocations in the Linux EIC shell workflow. - Removes the associated
FIXMEcomment referencing the upstream issue/workaround.
| File | Description |
|---|---|
| .github/workflows/linux-eic-shell.yml | Removes the CI-time exclusion of Irt collections so CI produces full outputs again. |
Review effort: Lite
Copilot stopped reviewing on behalf of
veprbl due to an error
November 5, 2026 21:15
wdconinc
approved these changes
Nov 5, 2026
Contributor
Capybara summary for PR 1206
Material map validation
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #1196 as the mitigation is now in EICrecon itself since eic/EICrecon#3067.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply