Repository navigation
Si disk with tiles - #1073
Draft
ShujieL wants to merge 84 commits into
Draft
Si disk with tiles #1073ShujieL wants to merge 84 commits into
ShujieL wants to merge 84 commits into
Conversation
…sk construction with tiles
for more information, see https://pre-commit.ci
github-actions
Bot
added
topic: infrastructure
Contributor
Author
|
The current code will read tile layout from SVT_endcap_tiles.csv, and place them in each disk envelope volume. The disk envelope is a SubtractionSolid = Disk - two beampipe tubes. It won't run with EICrecon: I submitted an ACT issue at acts-project/acts#5320 |
Contributor
Capybara summary for PR 1073
|
… the RSU sensor tiles
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Replace the sharp flat/web junctions of the explicit corrugation table with rounded bends of 5 mm mid-surface radius (SiEndcapCorrugation_bend_radius). flat_width_mm keeps its sharp-corner (apex) meaning; each joined flat end and web end is trimmed by R*tan(alpha/2) = 2.071 mm and a cylindrical shell sector (radii R -/+ t/2, axis along x) is placed in between, clipped against the disk edge and beam-pipe openings like the boxes. bend_radius = 0 reproduces the previous geometry. All joins are validated before any piece is placed. ROOT overlap checks (option m, 0.01 mm) are clean for epic_craterlake_tracking_only and epic_craterlake. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
for more information, see https://pre-commit.ci
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Assemble SVT disk with sensor tiles.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?