Skip to content

Setup new far backwards geometry - #1004

Draft
simonge wants to merge 72 commits into
mainfrom
Setup-new-far-backwards-geoemtry
Draft

simonge wants to merge 72 commits into
mainfrom
Setup-new-far-backwards-geoemtry

Conversation

@simonge

@simonge simonge commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

Briefly, what does this PR introduce?

Makes the changes required to match the current EIC accelerator beamline setup in the Far Backward region. The vacuum pipe spanning the tagger drift volume has needed some significant revisions, simplifying the implementation but removing some functionality to allow the "antechamber" design.

Incorporates the volumes reviewed in #978, placed correctly.

Introduces a new script which automatically updates the xml description of the magnets, strengths and positions based on a provided twiss and survey file. (The current files have been added to the calibrations but could be removed as don't do anything other than act as an input to the script.)

Some extra tinkering of positions may be required. In particular the luminosity pipe along the z-axis doesn't extend into the B2AeR magnet. There is a small vacuum/air boundary between the tagger exit windows and the beampipe cylinder. These could be fixed in this PR or a future PR as they won't have the most significant impacts.

The Luminosity components will need their positions updated to match the new layout.

Not the cleanest PR.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Hopefully nothing.

Does this PR change default behavior?

There is likely to be significant changes to the acceptance and reconstruction of the taggers.

@simonge simonge changed the title Setup new far backwards geoemtry Setup new far backwards geometry Nov 19, 2025
@simonge

simonge commented Nov 19, 2025

Copy link
Copy Markdown
Contributor Author

Visual comparison between the CAD and simulation. Looks like definitely some positions to adjust still.
image
image

@veprbl

veprbl commented Apr 1, 2026

Copy link
Copy Markdown
Member

Is the problem with generate-prim-file here that my hideous boolean volume has too many nested layers?

Could be. Perhaps we can use another geometry configuration to generate prim files. cc @wdconinc

@wdconinc

wdconinc commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Is the problem with generate-prim-file here that my hideous boolean volume has too many nested layers?

Could be. Perhaps we can use another geometry configuration to generate prim files. cc @wdconinc

Just change it to central only, maybe? But "hideous boolean volume has too many nested layers" can be a problem in its own right... regardless of whether dawn is what barfs on it first.

@veprbl

veprbl commented Apr 1, 2026

Copy link
Copy Markdown
Member

Agreed with @wdconinc, but I think it's also fair to say, despite how much of a technical marvel dawn is, we are not looking to support it indefinitely. So I would not sink time into debugging geometries for it when you can descope.

@wdconinc

This comment was marked as off-topic.

@veprbl

This comment was marked as off-topic.

@veprbl

This comment was marked as off-topic.

@simonge

simonge commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

Agreed with @wdconinc, but I think it's also fair to say, despite how much of a technical marvel dawn is, we are not looking to support it indefinitely. So I would not sink time into debugging geometries for it when you can descope.

Thanks, I've temporarily removed it while I debug other issues.

@simonge

simonge commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

Looks like the BENCHMARKS_TAG has changed so that some benchmark jobs aren't being triggered as it doesn't contain nightly anymore.
https://github.com/eic/detector_benchmarks/blob/master/benchmarks/lowq2_reconstruction/config.yml#L31

Is there a safer approach would stop this happening again?

@veprbl

veprbl commented Apr 2, 2026

Copy link
Copy Markdown
Member

(Was resolved in eic/detector_benchmarks#269)

We don't run extra nightly to conserve CI resource.

@simonge

simonge commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

Is onnxruntime not available for python 3.13? Or am I missing something?
https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/7504460#L101

From looking in the containers repository it appeared the requirements for the job might already be in the container?
https://github.com/eic/detector_benchmarks/blob/master/benchmarks/lowq2_reconstruction/requirements.txt
https://github.com/eic/containers/blob/master/spack-environment/ci/spack.yaml#L63

@veprbl

veprbl commented Apr 2, 2026

Copy link
Copy Markdown
Member

Maybe you need to update version constraints in the requirements.txt?

This branch was previously deployed

1 inactive (outdated) deployment
github-pages — cb909b78 Deployed Oct 26, 2026 by pre-commit-ci[bot] via deploy-artifacts-page #6159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants