Repository navigation
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
61
to
68
| expected <- .refit_cluster_draws( | ||
| model, | ||
| data, | ||
| group, | ||
| 20, | ||
| iterations, | ||
| 42, | ||
| sim = sim, | ||
| relabel = relabel | ||
| ) |
Contributor
There was a problem hiding this comment.
[air] reported by reviewdog 🐶
Suggested change
| expected <- .refit_cluster_draws( | |
| model, | |
| data, | |
| group, | |
| 20, | |
| iterations, | |
| 42, | |
| sim = sim, | |
| relabel = relabel | |
| ) | |
| expected <- .refit_cluster_draws(model, data, group, iterations, 42, relabel = relabel) |
| verbose = FALSE | ||
| )) | ||
| } | ||
| expect_no_condition(model_parameters(m_single, standardize = "std.nox", verbose = FALSE)) |
Contributor
There was a problem hiding this comment.
[air] reported by reviewdog 🐶
Suggested change
| expect_no_condition(model_parameters(m_single, standardize = "std.nox", verbose = FALSE)) | |
| expect_no_condition(model_parameters( | |
| m_single, | |
| standardize = "std.nox", | |
| verbose = FALSE | |
| )) |
| out <- model_parameters(m_single, standardize = "latent") | ||
| expect_true(.has_footer(out, " (type: std.lv).")) | ||
| expect_false(.has_footer(model_parameters(m_single))) | ||
| expect_false(.has_footer(model_parameters(m_single, standardize = TRUE, verbose = FALSE))) |
Contributor
There was a problem hiding this comment.
[air] reported by reviewdog 🐶
Suggested change
| expect_false(.has_footer(model_parameters(m_single, standardize = TRUE, verbose = FALSE))) | |
| expect_false(.has_footer(model_parameters( | |
| m_single, | |
| standardize = TRUE, | |
| verbose = FALSE | |
| ))) |
| cells <- lapply(strsplit(rows, "|", fixed = TRUE), trimws) | ||
| header <- cells[[1]] | ||
| body <- cells[-1] | ||
| expect_identical(vapply(body, function(x) x[header == "p.1"], character(1)), c("a", "b", "c")) |
Contributor
There was a problem hiding this comment.
[air] reported by reviewdog 🐶
Suggested change
| expect_identical(vapply(body, function(x) x[header == "p.1"], character(1)), c("a", "b", "c")) | |
| expect_identical( | |
| vapply(body, function(x) x[header == "p.1"], character(1)), | |
| c("a", "b", "c") | |
| ) |
| mp <- model_parameters(pw, p_adjust = method) | ||
| expect_equal(mp$p, stats::p.adjust(p_raw, methods[[method]]), tolerance = 1e-10) | ||
| } | ||
| expect_false(any(grepl("p-value adjustment method", capture.output(print(mp)), fixed = TRUE))) |
Contributor
There was a problem hiding this comment.
[air] reported by reviewdog 🐶
Suggested change
| expect_false(any(grepl("p-value adjustment method", capture.output(print(mp)), fixed = TRUE))) | |
| expect_false(any(grepl( | |
| "p-value adjustment method", | |
| capture.output(print(mp)), | |
| fixed = TRUE | |
| ))) |
| out <- capture.output(print(mp)) | ||
| expect_true(any(startsWith(out, "Parameter"))) | ||
| expect_false(any(grepl("p-value adjustment method", out, fixed = TRUE))) | ||
| expect_false(any(grepl("p-value adjustment method", capture.output(print(mp)), fixed = TRUE))) |
Contributor
There was a problem hiding this comment.
[air] reported by reviewdog 🐶
Suggested change
| expect_false(any(grepl("p-value adjustment method", capture.output(print(mp)), fixed = TRUE))) | |
| expect_false(any(grepl( | |
| "p-value adjustment method", | |
| capture.output(print(mp)), | |
| fixed = TRUE | |
| ))) |
| out <- capture.output(print(mp)) | ||
| expect_true(any(startsWith(out, "contrast"))) | ||
| expect_false(any(grepl("p-value adjustment method", out, fixed = TRUE))) | ||
| expect_false(any(grepl("p-value adjustment method", capture.output(print(mp)), fixed = TRUE))) |
Contributor
There was a problem hiding this comment.
[air] reported by reviewdog 🐶
Suggested change
| expect_false(any(grepl("p-value adjustment method", capture.output(print(mp)), fixed = TRUE))) | |
| expect_false(any(grepl( | |
| "p-value adjustment method", | |
| capture.output(print(mp)), | |
| fixed = TRUE | |
| ))) |
Contributor
There was a problem hiding this comment.
[air] reported by reviewdog 🐶
parameters/tests/testthat/helper-cluster_bootstrap.R
Lines 6 to 13 in 19e9306
Contributor
There was a problem hiding this comment.
[air] reported by reviewdog 🐶
parameters/tests/testthat/test-format_parameters.R
Lines 397 to 415 in 19e9306
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several of my recent PRs added more tests than the changes needed: checking for rare edge cases, the same check repeated across model classes or inputs, extra model fits, and long comments. Sorry for the extra review load and CI time this caused.
This PR removes the redundant tests. Each fixed behavior keeps one regression test, and no R code changes.