Repository navigation
Fix standard_error() for skewness and kurtosis from datawizard
#1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7c04714
Add tests for standard errors of skewness and kurtosis output
jmgirard 15f6f75
Return standard errors of skewness and kurtosis output from datawizard
jmgirard 352fce6
Add NEWS entry for skewness and kurtosis standard errors
jmgirard 2d9e6bb
Correct comments about where the skewness SE attribute came from
jmgirard 7b9b7bb
Test standard errors of skewness output against known values
jmgirard 947a012
Skip the bootstrapped standard error test without boot
jmgirard a257dab
shorten NEWS entry and comment
jmgirard bfe0e69
Trim tests
jmgirard 7cf8764
Bump version
jmgirard 560db1a
Merge remote-tracking branch 'origin/main' into HEAD
jmgirard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,19 @@ | ||
| #' @export | ||
| standard_error.parameters_skewness <- function(model, ...) { | ||
| attributes(model)$SE | ||
| # datawizard returns SE as column, older objects stored it as attribute | ||
| if ("SE" %in% names(model)) { | ||
| model$SE | ||
| } else { | ||
| attributes(model)$SE | ||
| } | ||
| } | ||
|
|
||
|
|
||
| #' @export | ||
| standard_error.parameters_kurtosis <- standard_error.parameters_skewness | ||
|
|
||
| #' @export | ||
| standard_error.datawizard_skewness <- standard_error.parameters_skewness | ||
|
|
||
| #' @export | ||
| standard_error.datawizard_kurtosis <- standard_error.parameters_skewness |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| skip_if_not_installed("datawizard") | ||
|
|
||
| test_that("standard_error returns the SE column of skewness and kurtosis output", { | ||
| out <- datawizard::skewness(mtcars[c("mpg", "cyl", "disp")]) | ||
| expect_identical(standard_error(out), out$SE) | ||
| out <- datawizard::kurtosis(mtcars$mpg) | ||
| expect_identical(standard_error(out), out$SE) | ||
| }) | ||
|
|
||
| test_that("standard_error works for the datawizard_* classes", { | ||
| s <- datawizard::skewness(mtcars$mpg) | ||
| class(s) <- c("datawizard_skewness", "data.frame") | ||
| expect_identical(standard_error(s), s$SE) | ||
|
|
||
| k <- datawizard::kurtosis(mtcars$mpg) | ||
| class(k) <- c("datawizard_kurtosis", "data.frame") | ||
| expect_identical(standard_error(k), k$SE) | ||
| }) | ||
|
|
||
| test_that("standard_error reads the SE attribute of old objects", { | ||
| s <- 0.67 | ||
| attr(s, "SE") <- 0.39 | ||
| class(s) <- c("parameters_skewness", "numeric") | ||
| expect_identical(standard_error(s), 0.39) | ||
| }) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.