You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(core): fall back to full git status when the config cannot be read - #971
Use the full status refresh when the Git config fails to load, instead of returning no status. Break grep ranking ties by address in every sort path, so full and partial ranking give the same order. Use the project's parking_lot mutex for bigram column allocation.
Repository status scanning now falls back to a full scan when repository settings cannot be read, improving reliability for large repositories on Linux.
Search results with equal relevance scores now use consistent ordering, including when the app switches between ranking methods. This makes tied results less dependent on the order in which files were provided.
The change makes Git status fall back to the full scan when the config cannot be loaded, makes grep ranking ties consistent, and removes a poisoned-mutex panic. No concrete merge-blocking risk remains.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 3 files.
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the Git status fallback change, which is a primary objective of the pull request. It does not mention the two smaller related fixes, but the title need not co…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title clearly and concisely describes the Git status fallback change, which is a primary objective of the pull request. It does not mention the two smaller related fixes, but the title need not cover every change.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: 83e8ddd4-374f-47a9-9dad-cb97b846c594
Commits
Reviewing files that changed from the base of the PR and between d1c7dd4 and 5f77857.
Files selected for processing: 3
crates/fff-core/src/git.rs
crates/fff-core/src/grep/prefilter.rs
crates/fff-core/src/index/bigram_filter.rs
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
Use the full status refresh when Git config fails to load. Break grep ranking ties by address in every sort path. Use the parking_lot mutex for bigram column allocation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-reviewedReview completed; does not imply approval
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the full status refresh when the Git config fails to load, instead of returning no status. Break grep ranking ties by address in every sort path, so full and partial ranking give the same order. Use the project's parking_lot mutex for bigram column allocation.
repo.config()?returned an error, so the picker had no git statusrank_with_tiesstd::sync::Mutexwithexpecton poisonparking_lot::MutexSummary by CodeRabbit