Repository navigation
run_test.sh: filter the pahole version warning header from make.log - #614
Merged
Merged
Conversation
Since Linux v7.0, commit 90e5b38a2652 ("kbuild: Sync kconfig when
PAHOLE_VERSION changes") makes external module builds print a warning
when the pahole version differs from the one used to build the kernel:
warning: pahole version differs from the one used to build the kernel
The kernel was built with: 131
You are using: 0
The last two lines are already filtered, but the first "warning: pahole
version differs ..." line is still left in make.log. This makes
run_test.sh fail with "unexpected make.log difference" on any testbed
where pahole is missing or its version does not match, e.g. Ubuntu
autopkgtest with 7.0 kernels.
Filter that line as well, in the same way as the compiler version
warning.
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
Member
|
This was happening on Fedora as well, but the issue was the updates in the repositories not exactly aligned; so the fix should be there. I will merge it anyway after the tests pass as it's useful to have. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Adds one rule to
generalize_make_log()inrun_test.shto drop thewarning: pahole version differs from the one used to build the kernelline frommake.logbefore comparison.Why
Since Linux v7.0, the kernel's top-level
Makefileprints this warning for external module builds when thepaholeversion in the environment differs from the one the kernel was built with:#609 (for #608) filtered the
The kernel was built with:line, and theYou are using:line is already covered by the compiler warning rule, but the first line is still left in the log. On testbeds withoutpahole(or with a different version),run_test.shstill fails:This is hit by Ubuntu test with 7.0 kernels.
How
/warning: the compiler differs from the one used to build the kernel/d / The kernel was built by:/d / You are using:/d +/warning: pahole version differs from the one used to build the kernel/d / The kernel was built with:/dThis mirrors the existing handling of the compiler version warning, where the header line and both detail lines are all filtered.