Repository navigation
xlnx_overlay_pl_dt: disable listed nodes only when hierarchical - #861
Merged
zeddii merged 1 commit intoOct 29, 2026
Merged
Conversation
arthokal
force-pushed
the
disable_listed_hierarchical_nodes
branch
from
October 29, 2026 08:42
f404aad to
b512ed8
Compare
The xlnx_overlay_pl_dt assist disables selected video IP nodes by matching xlnx,ip-name against a fixed list and setting status = "disabled". The same IP name is used for a hierarchical node inside a subsystem and for a standalone node. In a multimedia design where the v_tc node is standalone and is referenced as a bridge, it must remain enabled. The assist disables that node as well resulting in live video pipeline initialization to fail. The xlnx_overlay_pl_dt assist keeps the existing IP list and adds axi_gpio. A node is disabled only when it has xlnx,ip-name, that name is in the list, and the node has xlnx,is-hierarchy. The standalone v_tc has no xlnx,is-hierarchy, so it remains enabled. A hierarchical v_tc, is still disabled. A hierarchical axi_gpio is disabled only when its xlnx,name contains reset_sel_axis. The check runs on the overlay tree before YAML pruning can remove xlnx,is-hierarchy. The text rewrite that inserted status = "disabled" into pl.dtsi is removed. Signed-off-by: Aravind Thokala <aravind.thokala@amd.com>
arthokal
force-pushed
the
disable_listed_hierarchical_nodes
branch
from
October 29, 2026 08:47
b512ed8 to
b3d8745
Compare
Contributor
Author
|
@onkarharsh , please review. |
onkarharsh
approved these changes
Oct 29, 2026
onkarharsh
left a comment
onkarharsh
left a comment
Contributor
There was a problem hiding this comment.
Change looks good to me to merge for the time being. We must create a retrospective and go through these unique cases in coming weeks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
The xlnx_overlay_pl_dt assist disables selected video IP nodes by matching xlnx,ip-name against a fixed list and setting
status = "disabled". The same IP name is used for a hierarchical node inside a subsystem and for a standalone node.
In a multimedia design where the v_tc node is standalone and is referenced as a bridge, it must remain enabled. The assist
disables that node as well resulting in live video pipeline initialization to fail.
Fix:
The xlnx_overlay_pl_dt assist keeps the existing IP list and adds axi_gpio. A node is disabled only when it has
xlnx,ip-name, that name is in the list, and the node has xlnx,is-hierarchy. The standalone v_tc has no
xlnx,is-hierarchy, so it remains enabled. A hierarchical v_tc, is still disabled. A hierarchical axi_gpio is disabled
only when its xlnx,name contains reset_sel_axis. The check runs on the overlay tree before YAML pruning
can remove xlnx,is-hierarchy. The text rewrite that inserted status = "disabled" into pl.dtsi is removed.